Skip to content

Conversation

@Alokzh
Copy link

@Alokzh Alokzh commented Aug 6, 2025

Description

This PR introduces comprehensive unit tests for the ingress manifest functionality in the pkg/manifest package

How Has This Been Tested?

The new functionality has been validated through local unit testing:

go test -v ./pkg/manifest/...
go test -v ./pkg/manifest/... -cover

Tests cover:

  • Resource installation and deletion
  • Controller reference setup
  • Custom image handling
  • Duplicate operation handling

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?


Signed-off-by: Alokzh <zhalok24@gmail.com>
Copy link
Contributor

@gourishkb gourishkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change required in one test case. Looks good to me otherwise

Signed-off-by: Alokzh <zhalok24@gmail.com>
Copy link
Contributor

@gourishkb gourishkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Alokzh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants