fix: 转换大多数情况中外部css资源中的相对路径为绝对路径,防止404#73
Open
anchor123 wants to merge 4 commits intokuitos:masterfrom
Open
Conversation
anchor123
commented
Jun 22, 2021
- 添加了外部css内容处理函数,转换相对路径为绝对路径,防止加载失败。(针对引入外部cdn的情况)
- 添加了对应的单元测试内容
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 80.76% 81.42% +0.65%
==========================================
Files 3 3
Lines 338 350 +12
Branches 116 118 +2
==========================================
+ Hits 273 285 +12
Misses 59 59
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Author
|
@kuitos 作者您好,请问这个更改OK吗?能否发布到最新版呢 |
xtpss
reviewed
Jan 21, 2022
| // by daniel@2021-06-22 | ||
| let newBaseURI = baseURI; | ||
| if (baseURI.indexOf('//') === 0) { | ||
| newBaseURI = 'http:' + baseURI; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.