This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Draft
Conversation
Panefmm and c4.5 need to be updated as of 1.19.4 they are now 5t and not 4t
|
You updated it globally and so it will also be updated on 1.8. |
Author
|
Good point, I will try and figure out how to fix this |
Author
|
alright I have fixed the issue, sorry for all the opens and closes, this is my first PR |
Owner
|
I will think of a way to add version specific timings when i update the timing code to add optional inputs and mirrored strats, to not have a strats.json for every mc version. i will leave this open for now |
|
I would like to note that true pane fmm in 1.19.4+ is not -5t run 1t but sprintless -4t add sprint 1t later run 1t. This may not be best to put as the "normal" strat, so I suggest that all pane fmm-like timings be treated similarly with both the tick timing and run timing included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panefmm and c4.5 need to be updated as of 1.19.4 they are now 5t and not 4t