Skip to content

fix: socket was not connecting + enable reuse address #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvc0 merged 2 commits into from
Sep 27, 2025
Merged

fix: socket was not connecting + enable reuse address #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd024e3
fix: socket was not connecting + enable reuse port/address
anitarua Sep 26, 2025
3d958b6
set nonblocking, do not set reuse port
anitarua Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions protosocket-rpc/src/client/configuration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,25 +242,19 @@ where
{
log::trace!("new client {address}, {configuration:?}");

let socket = socket2::Socket::new(
match address {
SocketAddr::V4(_) => socket2::Domain::IPV4,
SocketAddr::V6(_) => socket2::Domain::IPV6,
},
socket2::Type::STREAM,
None,
)?;
let stream = TcpStream::connect(&address).await?;

// For setting socket configuration options available to socket2
let socket = socket2::SockRef::from(&stream);

let mut tcp_keepalive = TcpKeepalive::new();
if let Some(duration) = configuration.tcp_keepalive_duration {
tcp_keepalive = tcp_keepalive.with_time(duration);
}

socket.set_nonblocking(true)?;
socket.set_tcp_nodelay(true)?;
socket.set_tcp_keepalive(&tcp_keepalive)?;
Copy link
Owner

@kvc0 kvc0 Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think this is what this code should do:

    let stream = TcpStream::connect(&address).await?;
    // For setting socket configuration options available to socket2
    let socket = socket2::SockRef::from(&stream);

    let mut tcp_keepalive = TcpKeepalive::new();
    if let Some(duration) = configuration.tcp_keepalive_duration {
        tcp_keepalive = tcp_keepalive.with_time(duration);
    }

    socket.set_nonblocking(true)?;
    socket.set_tcp_nodelay(true)?;
    socket.set_tcp_keepalive(&tcp_keepalive)?;
    socket.set_reuse_address(true)?;

    let message_reactor: RpcCompletionReactor<


let stream = TcpStream::from_std(socket.into())?;
socket.set_tcp_nodelay(true)?;
socket.set_reuse_address(true)?;

let message_reactor: RpcCompletionReactor<
Deserializer::Message,
Expand Down