fix(1660): added fix for access token not getting deleted#636
Merged
timbastin merged 2 commits intol3montree-dev:mainfrom Feb 14, 2026
Conversation
Contributor
Author
|
@Hubtrick-Git @timbastin Thanks !! |
Member
|
@gauravshinde1816 Wow this is great! Thanks a lot for all that effort. There is only a single change needed: I think we do not need to close the dialog after deletion. Since the user is actually doing a provider setup, so deleting an old access token does not mean, he wants to stop setting up a different one. What do you think? |
Contributor
Author
|
Sure @timbastin |
…closing modal - Remove onClose prop from ProviderSetup component - Update handleDelete to use api.scrollTo(prevIndex) instead of closing modal - Remove onClose prop from RepositoryConnectionSlide wrapper - Remove onClose prop from RiskScannerDialog usage This ensures users can continue the integration setup flow after deletion since integrations are being auto-setup. Signed-off-by: gauravshinde1816@gmail.com Signed-off-by: gauravshinde1816@gmail.com <gauravshinde1816@gmail.com>
Contributor
Author
|
Hey @timbastin issue_1660_revise.mp4 |
Member
|
This is great! Thanks a lot! |
timbastin
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link :
l3montree-dev/devguard#1660
Changes Implemented
Recommendation for Future Improvement
I suggest migrating to a more robust state management solution such as Zustand. This would provide:
This is a recommendation for consideration. I'm happy to discuss the approach and can research implementation strategies for improving state management across the project if the team is interested.
Please let me know your thoughts on this proposal.
issue_1660_ui.mp4