Define all floats in interval methods to be float64 to match constructor#118
Open
ColtonPayne wants to merge 1 commit intomainfrom
Open
Define all floats in interval methods to be float64 to match constructor#118ColtonPayne wants to merge 1 commit intomainfrom
ColtonPayne wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a type inconsistency where intersection methods used
np.float32for default values when intervals are disjoint, while theIntervalstruct fields are defined asfloat64. Changed all default float values tonp.float64to match the constructor and avoid type coercion issues.Changes:
interval.py: Updated disjoint-interval defaults fromnp.float32tonp.float64interval_type.py: Same fix in the overloaded intersection used by JIT-compiled codeIssues
Closes #87
Closes #88