Skip to content

Conversation

@afieffe
Copy link
Contributor

@afieffe afieffe commented Apr 7, 2023

Skipping images with an evaluation already available in the time windows specified.

Skipping images with an evaluation already available in the time windows specified.
@jvogt
Copy link

jvogt commented May 23, 2023

Logic LGTM, but two suggestions:

  1. Let's make this optional (CLI flag), and turned off by default. Reasoning is container vulns endpoint is extremely verbose and even small lacework accounts can sometimes hit 100 pages (maximum pagination) of data returned for a 24 hour query. This takes a long time to paginate through (5-10 minutes) and may be an incomplete dataset. Don't want to negatively affect existing users.

  2. Can you add some documentation to the readme regarding the above mode and how it works? Also some word on how it compares to using the local cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants