Open
Conversation
trying syntax trying syntax trying syntax parsing and printing url parsing and printing line parsing and printing SmartFixVersion filepath parsing logs to reviews and creation trying a mapping between lines and positions trying a mapping between lines and positions debug trying a mapping between lines and positions debug trying a mapping between lines and positions debug continue trying a mapping between lines and positions debug continue changing body of comments grouping the vulnerabilities based on file and line reformat reformat delete experimentations reformat details reformat details reformat details reformat details retry a push for updates retry more details retry more details retry more details other CVE attempt reformatting reformatting reformatting reformatting
(Audit Mode) sca found potential 1 new issues
|
jeremydubreil
requested changes
Jan 17, 2025
Contributor
jeremydubreil
left a comment
jeremydubreil
left a comment
There was a problem hiding this comment.
Putting this PR as request changes until I test it carefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://lacework.atlassian.net/browse/COD-4173
This PR adds inline comments to alerts we send regarding weaknesses. An example is here: https://github.com/lacework-dev/WebGoat/pull/107
This is a first iteration that parses the contents of the markdown output of sca compare as source of information for creating the review comments. Will later use the sarif output and enable comments for secrets as well.