Skip to content

Don't return a nested array of paths in #with() too #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itiut wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't return a nested array of paths in #with() too #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ module.exports = {

with: function() {
var paths = Array.prototype.slice.call(arguments);
return [].concat.apply([bourbon.includePaths], paths);
return [].concat.apply(bourbon.includePaths, paths);
}
};
11 changes: 9 additions & 2 deletions test/with_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
var sass = require('node-sass')
, bourbon = require('../');
const chai = require('chai');
const assert = chai.assert;
const sass = require('node-sass');
const bourbon = require('../');

function partialsDir(path) {
return __dirname + '/fixtures/concat/' + path;
Expand All @@ -15,6 +17,11 @@ function errorHandler(err) {

describe('#with function', function() {

it('should return an array of paths', function() {
assert.isArray(bourbon.with());
assert.isString(bourbon.with()[0], 'first #with function path');
});

it('should concat string paths using #with', function(done) {
sass.render({
file: __dirname + '/fixtures/concat.scss',
Expand Down