fix: DuckDB initialization when either base prefix is not empty or a non-default project id is used. #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A couple of minor fixes related to the DuckDB query tab:
DuckDB assets
When the Lakekeeper UI sits on a non-empty base path, e.g.
/iceberg/ui, it would fail to load the DuckDB WASM assets as the logic to strip the path components removed the/icebergpart:These changes pass the configured
baseUrlPrefixthrough touseDuckDBfunction to allow it to find the assets.DuckDB attach for non-default project ids
In the case where a non-default project is used then the DuckDB attach statement requires the project id be prefixed to the catalog name.