fix(l1): align mempool error messages with their actual usage #5687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The human-readable messages for TxGasOverflowError and TxTipAboveFeeCapError were swapped. TxGasOverflowError is only used for arithmetic overflows while computing intrinsic gas in transaction_intrinsic_gas, and TxTipAboveFeeCapError is used when max_priority_fee_per_gas exceeds max_fee_per_gas in validate_transaction. This mismatch produced misleading logs and metrics but did not affect behavior. The change swaps the error annotations so that each variant's message matches its semantic meaning and call sites.