Skip to content

ci(l2): make tdx workflow fail fast if compilation of contract fails #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
JereSalo wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

ci(l2): make tdx workflow fail fast if compilation of contract fails #5700

JereSalo wants to merge 44 commits into from

Conversation

@JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Dec 22, 2025

Motivation

Description

JereSalo and others added 30 commits December 16, 2025 14:08
@JereSalo
timelock first steps
ac5726d
@JereSalo
improve some stuff and add comments
5e341dd
@JereSalo
add one more comment about security council
6138e29
@JereSalo
Deploy timelock contract and make it compile (not tested)
a2b631c
@JereSalo
remove comments
06429f5
@JereSalo
commit and verify batches to Timelock instead of OnChainProposer
75968ed
@JereSalo
add pause and unpause functions
ea206cb
@JereSalo
change mindelay to 30 seconds for testing
4e2ab15
@JereSalo
add emergency execution for security council
d390d97
@JereSalo
remove initialization of bridge address and transfer of ownership
6516788
@JereSalo
run cargo fmt
3545409
@JereSalo
fix solidity lint in Timelock
6a41d67
@JereSalo
use onlySelf modifier instead
ad29f8a
@JereSalo
merge main
af1f5d7
@JereSalo
rename error in based contract
8a8df36
@JereSalo
require timelock address to be set if it's not based
a5c12c7
@JereSalo
make tiny changes
9e740c4
@JereSalo
deploy timelock only on non-based
f697e23
@JereSalo
improve comments in timelock contract
e4dd641
@JereSalo
add comments to Timelock contract
43589a8
@JereSalo
rename owner to governance
1e6c0b2
@JereSalo
Merge branch 'main' into timelock_l2
89bc0ba
@JereSalo
disable initialize function from TimelockControllerUpgradeable
1369951
@JereSalo
Merge branch 'timelock_l2' of github.com:lambdaclass/ethrex into time…
a16cd29 
…lock_l2
@JereSalo
Make Timelock inherit IOnChainProposer
7edc1e0
@JereSalo
let security council upgrade vks
f68872f
@JereSalo
try fix timelock bug
90d7add
@JereSalo
add Clone
21a4d5d
@JereSalo
run cargo fmt
f8bce2a
@JereSalo
make tdx contract point to the timelock and this one implements autho…
fa3c723 
…rizedSequencerAddresses
@JereSalo JereSalo self-assigned this Dec 22, 2025
@github-actions github-actions bot added the L2 Rollup client label Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Dec 22, 2025 •
edited
Loading

Lines of code report

Total lines added: 7
Total lines removed: 0
Total lines changed: 7

Detailed view 
+----------------------------------+-------+------+
| File                             | Lines | Diff |
+----------------------------------+-------+------+
| ethrex/cmd/ethrex/l2/deployer.rs | 1488  | +7   |
+----------------------------------+-------+------+

Base automatically changed from timelock_l2 to main January 5, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilitteri ilitteri Awaiting requested review from ilitteri ilitteri will be requested when the pull request is marked ready for review ilitteri is a code owner

@ManuelBilbao ManuelBilbao Awaiting requested review from ManuelBilbao ManuelBilbao will be requested when the pull request is marked ready for review ManuelBilbao is a code owner

@avilagaston9 avilagaston9 Awaiting requested review from avilagaston9 avilagaston9 will be requested when the pull request is marked ready for review avilagaston9 is a code owner

@jrchatruc jrchatruc Awaiting requested review from jrchatruc jrchatruc will be requested when the pull request is marked ready for review jrchatruc is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@JereSalo JereSalo

Labels

L2 Rollup client

Projects

ethrex_l2
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JereSalo