-
Notifications
You must be signed in to change notification settings - Fork 144
perf(l1): remove storage store needless allocs #5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+50
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark for 6edc622Click to view benchmark
|
f3d1762 to
53567f7
Compare
Benchmark for 4551ae1Click to view benchmark
|
24a02f4 to
19d29a7
Compare
Benchmark for 992cae6Click to view benchmark
|
Benchmark for 93f4f73Click to view benchmark
|
Benchmark for 66fa6fdClick to view benchmark
|
This reverts commit 19d29a7.
Benchmark for f738be7Click to view benchmark
|
azteca1998
approved these changes
Dec 23, 2025
Benchmark for cea1356Click to view benchmark
|
pablodeymo
approved these changes
Dec 23, 2025
Contributor
pablodeymo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark for c6f7f60Click to view benchmark
|
Benchmark Block Execution Results Comparison Against Main
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Removes needless allocations due to the current api requiring a ref to a Vec
Description
Checklist
STORE_SCHEMA_VERSION(crates/storage/lib.rs) if the PR includes breaking changes to theStorerequiring a re-sync.Closes #issue_number