chore(l1): fast validate #5713
Open
chore(l1): fast validate #5713
+69
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark for 2c37b03Click to view benchmark
|
Benchmark for 398d407Click to view benchmark
|
Benchmark for e28a603Click to view benchmark
|
fedacking
force-pushed
the
fast-validate
branch
from
87ca44e to
e4f21e2
Compare
Benchmark for 60c8be6Click to view benchmark
|
Oppen
reviewed
Dec 23, 2025
Comment on lines
+534
to
+549
| for (_, node) in self.into_iter() { | ||
| expected_count -= 1; | ||
| match node { | ||
| Node::Branch(branch_node) => { | ||
| expected_count += branch_node | ||
| .choices | ||
| .iter() | ||
| .filter(|child| child.is_valid()) | ||
| .count(); | ||
| } | ||
| Node::Extension(_) => { | ||
| expected_count += 1; | ||
| } | ||
| Node::Leaf(_) => {} | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Are we checking the hashes match at some point? Does the iterator still do that?
Contributor
Author
There was a problem hiding this comment.
The iterator uses get_node_checked, which will stop the iteration, which will make expected_count return a value indicating that the trie is not valid.
Oppen
reviewed
Jan 5, 2026
Benchmark for 8b9433aClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to validate the tree quicker and consume less memory.
Description