Add optional save_to parameter to save the output to disk #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesoennichsen
force-pushed
the
dev/mikesoennichsen/save-to
branch
from
68de65a to
d9e7122
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an optional save_to parameter to the extract, parse, and split methods in the LandingAI ADE client, allowing users to automatically save API responses to JSON files on disk.
Key changes:
- Added
save_toparameter (typestr | Path | None) to three API methods in the sync client - Implemented file write logic using
Path(save_to).write_text(result.to_json())after each API call - Updated README.md with usage examples demonstrating the new parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/landingai_ade/_client.py | Added Path import and implemented save_to parameter for extract, parse, and split methods in the sync LandingAIADE client |
| README.md | Added documentation of the new save_to feature in the features list and updated code examples to demonstrate its usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikesoennichsen
force-pushed
the
dev/mikesoennichsen/save-to
branch
from
305297d to
a0cdb2e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MingruiZhang
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.