fix(gcs): List returns relative path instead of full path #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GCS List method was returning full paths (attrs.Name) instead of relative paths (key with prefix stripped). This was inconsistent with other storage implementations (S3, Local, Azure, Aliyun, Tencent, Huawei, Volcengine) which all return relative paths. The original implementation in dify-plugin-daemon PR #237 correctly used `key`: https://github.com/langgenius/dify-plugin-daemon/pull/237/files#diff-1efde200d0fa3fafdd827478fdbca6e8b16dee52955cb3c93faab2849f7d95bfR136 This bug was introduced when the code was ported to dify-cloud-kit. Also added a test assertion to verify that List returns relative paths. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Listmethod returning full paths (attrs.Name) instead of relative paths (key with prefix stripped)Listreturns relative pathsBackground
The original implementation in dify-plugin-daemon PR #237 correctly used
key, but it was mistakenly changed toattrs.Namewhen ported to dify-cloud-kit.Test plan
Listmethod returns relative paths