fix: accept plugin_unique_identifier from query params for DecodePluginFromIdentifier

[minodisk]

Summary

• Changed struct tag from json:"plugin_unique_identifier" to form:"plugin_unique_identifier" for DecodePluginFromIdentifier handler

Problem

The DecodePluginFromIdentifier endpoint was expecting plugin_unique_identifier in the JSON request body. However, this is a GET endpoint, and sending a body with GET requests causes issues with HTTP intermediaries like Google Cloud Run's frontend, which rejects such requests as malformed.

Solution

Changed from json: tag to form: tag, which binds the parameter from query string instead of JSON body. This is:

• Consistent with similar GET endpoints (FetchPluginManifest, FetchPluginFromIdentifier) which already use form: tags
• Compliant with HTTP standards (GET requests should not have semantic body content)
• Compatible with Cloud Run and other HTTP proxies/load balancers

Related PR

This change requires a corresponding change in dify:

• fix: use query params instead of request body for decode_plugin_from_identifier dify#31697

[gemini-code-assist]

Summary of Changes

Hello @minodisk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the DecodePluginFromIdentifier endpoint to correctly handle its plugin_unique_identifier parameter. Previously, this GET endpoint incorrectly expected the identifier in the request body, leading to failures with certain HTTP proxies. The update switches the parameter binding to use query parameters, aligning with standard HTTP practices for GET requests and improving overall system compatibility and robustness.

Highlights

• Parameter Binding Change: The plugin_unique_identifier parameter in the DecodePluginFromIdentifier handler has been updated to be bound from query parameters (form) instead of the request body (json).
• HTTP Standard Compliance: This change ensures that the DecodePluginFromIdentifier GET endpoint adheres to HTTP standards, as GET requests should not carry semantic body content.
• Compatibility Improvement: The modification resolves compatibility issues with HTTP intermediaries like Google Cloud Run's frontend, which reject GET requests containing a body.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where the DecodePluginFromIdentifier GET endpoint was improperly expecting a JSON request body. Changing the struct tag from json:"plugin_unique_identifier" to form:"plugin_unique_identifier" aligns the endpoint with HTTP best practices for GET requests by accepting the parameter from the query string. This change not only fixes the immediate problem with HTTP intermediaries but also makes the endpoint consistent with other similar GET endpoints in the codebase. The change is well-justified and correctly implemented.