-
Notifications
You must be signed in to change notification settings - Fork 124
feat: sync get_text_content from dify-api
#285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Stream29, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new utility method, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a get_text_content method to the PromptMessage class, which is a useful addition for extracting textual content from messages that might be multi-modal. The implementation is functionally correct, but I have a couple of suggestions. I've recommended a small refactor to make the code more concise and idiomatic, and also pointed out the need for unit tests to ensure the new functionality is robust.
| """ | ||
| return not self.content | ||
|
|
||
| def get_text_content(self) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new method is a helpful addition. To ensure it functions correctly under all conditions and to prevent future regressions, it would be beneficial to add unit tests. The tests should cover various scenarios, such as when content is a simple string, a list with mixed content types (including lists with no text content), an empty list, and None.
| text_parts = [] | ||
| for item in self.content: | ||
| if isinstance(item, TextPromptMessageContent): | ||
| text_parts.append(item.data) | ||
| return "".join(text_parts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved readability and conciseness, you can use a generator expression directly within "".join(). This is a more Pythonic approach and can be more memory-efficient for large lists as it avoids creating an intermediate list in memory.
| text_parts = [] | |
| for item in self.content: | |
| if isinstance(item, TextPromptMessageContent): | |
| text_parts.append(item.data) | |
| return "".join(text_parts) | |
| return "".join(item.data for item in self.content if isinstance(item, TextPromptMessageContent)) |
Pull Request Checklist
Thank you for your contribution! Before submitting your PR, please make sure you have completed the following checks:
Compatibility Check
README.mdREADME.mdREADME.mdREADME.mdAvailable Checks