Skip to content

refactor: replace compact response generation with length-prefixed response for backwards invocation api #20903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nov1c444 merged 1 commit into from
Jun 11, 2025
Merged

refactor: replace compact response generation with length-prefixed response for backwards invocation api #20903

Nov1c444 merged 1 commit into from
Jun 11, 2025

Conversation

@Yeuoly
Copy link
Contributor

@Yeuoly Yeuoly commented Jun 11, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #langgenius/dify-plugin-daemon#310
Fixes #langgenius/dify-plugin-daemon#309

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 11, 2025
@Yeuoly Yeuoly requested a review from Nov1c444 June 11, 2025 07:29
Nov1c444
Nov1c444 approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@Nov1c444 Nov1c444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 11, 2025
@Nov1c444 Nov1c444 merged commit d6d8cca into main Jun 11, 2025
10 checks passed
@Nov1c444 Nov1c444 deleted the refactor/length-prefixed-chunking-for-backwards-invocations branch June 11, 2025 08:01
@dosubot dosubot bot mentioned this pull request Jun 19, 2025
Closed
5 tasks
@syed-shah-zepto syed-shah-zepto mentioned this pull request Jun 23, 2025
Closed
5 tasks
@dosubot dosubot bot mentioned this pull request Jul 4, 2025
Closed
5 tasks
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
@Yeuoly @jsincorporated
refactor: replace compact response generation with length-prefixed re…
ec09780 
…sponse for backwards invocation api (langgenius#20903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nov1c444 Nov1c444 Nov1c444 approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yeuoly @Nov1c444