Warn about ignored attributes in configuration.#186
Open
jkot wants to merge 1 commit intolarsga:masterfrom
Open
Warn about ignored attributes in configuration.#186jkot wants to merge 1 commit intolarsga:masterfrom
jkot wants to merge 1 commit intolarsga:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to keep the changes minimal and I also tried to follow your style - e.g. by using the Logger interface and using the DummyLogger by default.
It's far from ideal because noone will see the warnings unless they set a logger to the ConfigLoader but it's a start.