Merged
Conversation
Fixes type inference warnings introduced in Elixir 1.19's enhanced type system: - Fix "expected a module" warnings by normalizing @message_builder at compile time - Fix "unreachable clause" warnings by using proper with expressions and case statements - Fix "never used" warnings by consolidating handle_init_result function clauses - Add missing lvs_refresh handler for complete Phoenix Channel compatibility - Use function_exported?/3 for robust message builder arity detection - Remove unused alias in mix task Changes maintain full backward compatibility with existing LiveState applications while eliminating all type system violations in Elixir 1.19. Resolves compilation warnings without breaking existing functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of the original PR by @liorix which configures build to use 1.19