Skip to content

fix #508: improve slot session key comparison in work-finish tool. #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netandreus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix #508: improve slot session key comparison in work-finish tool. #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/tools/worker/work-finish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,16 +224,20 @@ export function createWorkFinishTool(ctx: PluginContext) {
const { project } = await resolveProject(workspaceDir, channelId);
const roleWorker = getRoleWorker(project, role);

// Find the first active slot across all levels
// Find the first active slot across all levels that matches this session.
// Session keys can differ slightly in casing between the tool context and
// stored slot state, so comparisons are case-insensitive.
let slotIndex: number | null = null;
let slotLevel: string | null = null;
let issueId: number | null = null;

for (const [level, slots] of Object.entries(roleWorker.levels)) {
for (let i = 0; i < slots.length; i++) {
if (slots[i]!.active && slots[i]!.issueId &&
(!toolCtx.sessionKey || !slots[i]!.sessionKey ||
slots[i]!.sessionKey === toolCtx.sessionKey)) {
const slot = slots[i]!;
if (slot.active && slot.issueId &&
(!toolCtx.sessionKey || !slot.sessionKey ||
(slot.sessionKey && toolCtx.sessionKey &&
slot.sessionKey.toLowerCase() === toolCtx.sessionKey.toLowerCase()))) {
slotLevel = level;
slotIndex = i;
issueId = Number(slots[i]!.issueId);
Expand Down