fix: issue with the picker not opening on ios with the new architecture#542
fix: issue with the picker not opening on ios with the new architecture#542exlymex wants to merge 1 commit intolawnstarter:masterfrom
Conversation
|
does this have any regressions on the previous architecture? |
|
When I do this I can click on the picker, but the modal that opens goes to the top of the screen and is not visible. |
NoodleOfDeath
left a comment
There was a problem hiding this comment.
This looks good. Can we merge this ASAP?
|
Agreed, this fixes the breaking change with Expo SDK 52. |
This fix should be enough to fix this problem. And after doing a regression, I didn't notice any new problems arise. |
no new problems <<<< breaking changes IMPO (in my personal opinion) this needs to be expedited sooner than later |
|
@exlymex can you fix the conflicts? |
|
Please, can this PR be merged? This can help resolve this particular issue. Please fix the conflict @exlymex |
|
In the meantime you can now pass the props to the Picker: |
On the new architecture the TextInput used to display the text was intercepting events. This seems to be caused by the view-flattening algorithm moving it out of the parent view which has pointerEvents="box-only" set.
The solution would be either to add pointerEvents="none" to the TextInput itself, as done in this PR, or to disable the view flattening for the parent view (by adding collapsable={false} prop to it), so the native view structure would match the react one.