Improve grok pattern for firewall rules#1
Open
LoudSoftware wants to merge 1 commit intolawrencesystems:mainfrom
Open
Improve grok pattern for firewall rules#1LoudSoftware wants to merge 1 commit intolawrencesystems:mainfrom
LoudSoftware wants to merge 1 commit intolawrencesystems:mainfrom
Conversation
…ESCR - Added support for ICMP-specific fields: TYPE, CODE, ID, SEQ - Captured standalone TCP flags (SYN, ACK, RST, FIN, etc.) as optional literals - Switched IP fields to IPORHOST to allow for IPv6 matching - Made optional fields like MAC, UID, GID, LEN, SEQ, ACK more robust - Updated DESCR field parsing to support both [Group]Rule and plain text formats - Improved overall compatibility with varying log structures
|
@LoudSoftware I'm using your extractors and they work great -- thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After noticing some messages not matching against the current pattern, I took the liberty of tweaking it to add the following:
Note: This was implemented and tested in a pipeline rule, while I'm almost confident it would work in an extractor, it should be tested first.