Support for PyCharm's console#10
Open
marck0z wants to merge 3 commits intolaysakura:masterfrom
marck0z:master
Open
Support for PyCharm's console#10marck0z wants to merge 3 commits intolaysakura:masterfrom marck0z:master
marck0z wants to merge 3 commits intolaysakura:masterfrom
marck0z:master
Conversation
rainbow_logging_handler/__init__.py
Outdated
| self, stream, | ||
|
|
||
| datefmt='%H:%M:%S', | ||
| passthrough=False, |
Owner
There was a problem hiding this comment.
The name passthrough seems not understandable enough.
How about ignore_tty_check ?
Collaborator
|
Hi! I took over the project maintenance. Can you add an example how you are using this with PyCharm, so I can test out? I am another PyCharm using fellow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using PyCharm's console the output is not colorized, this is because PyCharm uses redirected streams and as a result
self.is_ttyis always false, forzing the use ofStreamHandler.format(self, record)instead ofself.colorize(record), even though PyCharms supports ANSI codes fine.As far as I know, there isn't a way to automatically detect if a stream supports ANSI codes, so I added the flag
passthroughto be able to ignoreself.is_ttycheck.