More flexible column detection in complex format strings#9
Open
staticglobal wants to merge 2 commits intolaysakura:masterfrom
Open
More flexible column detection in complex format strings#9staticglobal wants to merge 2 commits intolaysakura:masterfrom
staticglobal wants to merge 2 commits intolaysakura:masterfrom
Conversation
python printf-style format strings, such as those used by the logging formatter, have provisions for many advanced field conversions such as field widths, padding characters, etc. For example, you can force the "msecs" to always be a zero-padded 3-digit field by specifying "%(msecs)03d". However, modifiers such as these breaks rainbow_logging_handler which is looking for a strict string match for "%(msecs)d". This change enhances rainbow_logging_handler to detect and cope with (almost) any field conversion modifiers and still apply the appropriate colors.
Author
|
Also adds a new dependency on the "re" standard library |
Collaborator
|
Hi! I am taking over the library maintenance. Can you please add an automated test case to stress out this functonality and it's good to merge. |
|
+1 - for this feature. The current date stamp format doesn't support the ms precision we need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python printf-style format strings, such as those used by the logging
formatter, have provisions for many advanced field conversions such as
field widths, padding characters, etc. For example, you can force the
"msecs" to always be a zero-padded 3-digit field by specifying
"%(msecs)03d". However, modifiers such as these breaks
rainbow_logging_handler which is looking for a strict string match for
"%(msecs)d".
This change enhances rainbow_logging_handler to detect and cope with
(almost) any field conversion modifiers and still apply the appropriate
colors.