truncates long queries in error pop-up to keep 'ok' button on screen #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated chrome/resoure/sqlite.js onSqlError function to limit restatement of SQL query to only first 10 lines for long queries so that the bottom of the alert pop-up stays on screen. A '...' is appended to the end of truncated queries. Other error information on the pop-up is left alone.
Author
|
Did I do something wrong with this pull request? I thought this project was maybe dead but now I see that there have been some other pull requests accepted in the last few months. I'm new to github so please tell me if I should have done something differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated chrome/resource/sqlite.js onSqlError function to limit restatement of SQL query to only
first 10 lines for long queries so that the bottom of the alert pop-up stays on screen. A '...' is
appended to the end of truncated queries. Other error information on the pop-up was left alone.