Skip to content

Include component name in path for nested modifications #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JayHuLBL merged 1 commit into from
Jan 20, 2026
Merged

Include component name in path for nested modifications #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server/src/parser/modification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,9 @@ function unpackModblock(props: ModificationProps) {
) as mj.ClassMod;
// Additional modifiers can be attached to choice
if (classModification) {
mods = getModificationList(classModification, basePath, value);
// Include component name in path for nested modifications
const nestedBasePath = [basePath, name].filter((s) => s).join(".");
mods = getModificationList(classModification, nestedBasePath, value);
// TODO: getModificationList should handle redeclares but it is not
// correctly unpacking nested modifiers - this is a bug
// kludge: remove nested modifiers
Expand All @@ -264,7 +266,9 @@ function unpackModblock(props: ModificationProps) {
const modType = modElement?.type;
typePath = modType ? modType : baseType;
}
mods = getModificationList(mod as mj.ClassMod, basePath, typePath); //mod.class_modification
// Include component name in path for nested modifications
const nestedBasePath = [basePath, name].filter((s) => s).join(".");
mods = getModificationList(mod as mj.ClassMod, nestedBasePath, typePath);
}
}

Expand Down