Add pre-commit hooks #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Also, I know that 18 changed files is a lot to review. Sorry! But the changes are really only cosmetic (mostly stripping excess whitespace from end of lines). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'd like to suggest adding pre-commit hooks to this project. I have added some basic hooks which will clean up white-space on each commit. This already contributes to code quality. Next steps I'd suggest would be to add some hooks to apply some code formatting and static analysis (see https://github.com/pocc/pre-commit-hooks). We use these hooks on most of our projects and find that they make our code significantly neater and easier to maintain. Best regards, Andrew.