aggregation: cleanup and reorg #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if TYPE_CHECKING: | ||
| from lean_spec.subspecs.containers.attestation import AggregationBits | ||
| data_root: Bytes32 |
Contributor
There was a problem hiding this comment.
Why not just make it bytes? Right now you have to wrap root field in Bytes32 in every function call.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the observation, to have a stronger typing, I changed instead the return type of data_root_bytes() function to have Bytes32 directly and so we don't need wrappers anymore :)
anshalshukla
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
@anshalshukla I've tried some kind of cleanup, let me know what you think about it?
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox