Fix issue where SAML assertion validation fails if namespace is not defined on Signature node.#20
Open
cmordue wants to merge 1 commit intoleandrob:masterfrom
Open
Fix issue where SAML assertion validation fails if namespace is not defined on Signature node.#20cmordue wants to merge 1 commit intoleandrob:masterfrom
cmordue wants to merge 1 commit intoleandrob:masterfrom
Conversation
…efined on Signature node. Remove namespace-breaking reserialization of signature which used to be in the documented example from xml-crypto but was removed due to this bug See: node-saml/xml-crypto#105
niinpatel
approved these changes
Jul 13, 2020
|
Can we get this PR merged? This is causing errors for some saml implementations at our org |
chrisgarber
added a commit
to abacuslabs/saml20
that referenced
this pull request
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove namespace-breaking reserialization of signature which used to be in the documented example from xml-crypto but was removed due to this bug
See: node-saml/xml-crypto#105