Skip to content

Conversation

@dupuisf
Copy link
Contributor

@dupuisf dupuisf commented Jun 10, 2024

This PR adds a deprecation alias that was missing from #10088.


Open in Gitpod

@dupuisf dupuisf added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. labels Jun 10, 2024
@dupuisf dupuisf requested a review from Ruben-VandeVelde June 10, 2024 15:52
@github-actions
Copy link

PR summary

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@github-actions github-actions bot removed the awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. label Jun 10, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!
maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 10, 2024
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 10, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 10, 2024
This PR adds a deprecation alias that was missing from #10088.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 10, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jun 10, 2024
This PR adds a deprecation alias that was missing from #10088.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: add deprecation alias [Merged by Bors] - fix: add deprecation alias Jun 10, 2024
@mathlib-bors mathlib-bors bot closed this Jun 10, 2024
@mathlib-bors mathlib-bors bot deleted the dupuisf/card_fiberwise_deprecation branch June 10, 2024 20:33
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
This PR adds a deprecation alias that was missing from #10088.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants