-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(Analysis/SpecialFunctions/Gamma):add BinetKernel part 1 #34335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR 3 on HadamardFactorization pipeline co-authored by Jonathan Washburn and Matteo Cipollina
feat(Analysis/SpecialFunctions/Gamma):add BinetKernel
PR summary 18ef4ef4f3Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
🚨 PR Title Needs FormattingPlease update the title to match our commit style conventions. Errors from script: Details on the required title formatThe title should fit the following format:
|
|
Maybe other reviewers can help but isn't it possible for so many private lemmas to be in a private section? Usually for mathlib we expose all. |
|
Hey I see that you have 20 PR's opened in the span of a few hours, with one of those having at least 6k LoC. Maybe it makes sense to open a Zulip thread with your additions so that you get more direct feedback. |
Hi, these are prerequisites for the application of Hadamard Factorization to the zeta function. Some preliminary discussion anticipating the PR cycle here and here. Most of these are connected, the large one is on purpose still a draft as it will require to decide, among other things, whether to crate a dedicated folder for Hadamard/Divisor API. |
Co-authored-by: metakunt <166170055+metakunt@users.noreply.github.com>
PR 3a on HadamardFactorization pipeline
Co-authored with Matteo Cipollina (matteo.cipollina@yahoo.it)