Skip to content

Conversation

@eric-wieser
Copy link
Member

Doing this prevents the many lemmas we have about Pi.single applying.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

PR summary 725d7a32b7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen
Copy link
Collaborator

themathqueen commented Jan 23, 2026

I think we should always use Pi.single instead of the bare functions one (regardless if it's a simp imo). Are there any more of these? I remember a PR a few months back that changed some to use Pi.single. I don't think it ever got merged yet, let me try finding it (edit: #31949).

@eric-wieser
Copy link
Member Author

I generally agree, but I don't think we need to make that change all at once.

Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 24, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 24, 2026
Doing this prevents the many lemmas we have about `Pi.single` applying.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 24, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: don't unfold Pi.single in a simp lemma [Merged by Bors] - chore: don't unfold Pi.single in a simp lemma Jan 24, 2026
@mathlib-bors mathlib-bors bot closed this Jan 24, 2026
@mathlib-bors mathlib-bors bot deleted the eric-wieser/more-single branch January 24, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants