Basic html file + styling #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toozej
approved these changes
Nov 5, 2019
Member
|
Can you include a screencap of what this looks like when rendered? |
Member
|
Also can you add comments so someone else in the future who doesn't know much about HTML and CSS can jump in here and know what the code does? This will make it easier to get other people involved in managing the website. |
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@objectsforheads
@toozej
Fixes Issue(s)
learntouselinux/learntouselinux#39
Explanation
Created basic html file, added some styling to vertically and horizontally center the title element.
display: flexwas used to center thetitleelement. I decided to simply using divs instead of a p tag to accomplish this.Rationale
V1 of the index file was just a single line of text. To organize the index.html file and style it, a basic html layout is necessary.
Tests
Runs locally when opening index.html in google chrome