Open
Conversation
* readme now explains the structure of the directories. * config.json now lists the exercises in an order similar to Elixir.
Also ignore emacs ~ files.
Using escript to run tests is faster (1 second instead of 30). To integreate better with eunit, tests are now suffxed with _tests.erl. word_count needed a change to compile. bank_account and binary_string needed renaming to fit the pattern.
Check exercises escript
Owner
There was a problem hiding this comment.
Let's hide all the number manipulation in the width function:
width(Len) ->
Sqrt = trunc(math:sqrt(Len)),
width1( Sqrt, Len).
width1( Sqrt, Len) when Sqrt*Sqrt < Len ->
Sqrt + 1;
width1( Sqrt, _) ->
Sqrt.
This makes it easier to read the flow of the code.
Author
There was a problem hiding this comment.
Yes, you are right. The square root is better off hidden in width/1.
I still hold out for my variable names, though. I think Length is better than Len.
How come you are comparing "Sqrt*Sqrt < Len", instead of my "Square_root > Trunc"?
Will the latter give wrong answers?
Owner
There was a problem hiding this comment.
Your variable names are the best.
The two comparisons should do the same. I went for S*S<L because it seemed more natural in my head to focus on making sure that the square area covers the entire length. Either way is fine by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.