Open
Conversation
When a file is moved and a new file takes its place at the same path, the hash cache would incorrectly reuse the old hash, leading to wrong duplicate detection and potential data loss with delete actions. Changes: - Use composite cache keys (path, mtime, size) instead of path alone - Automatically cleanup old entries when a file at the same path is updated - Validate file modification time and size before using cached hash - Automatic migration from old cache format with backward compatibility - Add test case for file replacement scenario - Bump version to 0.11.11 Technical implementation: - Cache type changed from Dict[Path, Hash] to Dict[Tuple[Path, float, int], Hash] - On get(): construct key from current file stats, return None if no match - On add(): remove any existing entries for the path, add new composite key - Migration: old format entries get dummy metadata (0.0, 0) and are recalculated on first access - Both JSON and Pickle formats supported with automatic format detection This fix prevents dangerous false positives that could lead to accidental data deletion while maintaining performance and cache efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a file is moved and a new file takes its place at the same path, the hash cache would incorrectly reuse the old hash, leading to wrong duplicate detection and potential data loss with delete actions.
Changes:
Technical implementation:
This fix prevents dangerous false positives that could lead to accidental data deletion while maintaining performance and cache efficiency.