Open
Conversation
657e1d0 to
9805bb6
Compare
|
Is the intent of these tests to show that the python3 migration hasn't broken anything or to allow for less guess work in refactoring? Because if it is the former they should be merged to upstream so they can be run against both versions and the latter I think it make sense to wait until after the python3 stuff is merged? To not make the PR even bigger and harder to review. |
e9a2107 to
d320c4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt to cover slskmessages module with unit tests and then clean up things a bit