✨ add support for babel-plugin-macros#64
✨ add support for babel-plugin-macros#64intellild wants to merge 4 commits intoleonardfactory:masterfrom
Conversation
|
Hi @leonardfactory can you look at this ? |
leonardfactory
left a comment
There was a problem hiding this comment.
Hi and thank you for your contribution! I left my two cents here
| "peerDependencies": { | ||
| "babel-plugin-macros": "^3.1.0" | ||
| }, |
There was a problem hiding this comment.
I'm a bit worried about this, since babel-plugin-macro is not strictly a dependency, but an optional one. An idea would be to use peerDependenciesMeta in order to specify they're optional, even if this would require additional checking in actual code. Can you take a look at this?
|
@leonardfactory I made the babel-plugin-macros dependency optional |
|
Hi @intellild, I didn't have time to analyze this correctly before; now I'm wondering which use case you are trying to cover here. I'm genuinely curious about your proposal, I'll try to explain my point of view. The plugin works well when you need to work with
Furtermore this plugin tries to emulate (with a best-effort strategy) the official TypeScript feature Given all of that, I'm curious about the macro usage and I'd like to hear back from you before including it in the package – I'm just worried it could bring a bit of confusion to future and existing users. |
|
@leonardfactory
|
support babel-plugin-macros
example: