Show failure message with actual arguments#79
Open
kyanny wants to merge 3 commits intoleshill:masterfrom
Open
Conversation
lib/resque_spec/matchers.rb
Outdated
Owner
|
Hi @kyanny, Looks good once the commit is cleaned up. Would you create a spec to verify that the messages are being generated correctly in |
Author
|
Hi @leshill Thank you for your review! I'm going to figure out how to write test against failure messages and do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some matchers of ResqueSpec shows expected arguments in failure message but not show actual arguments.
This change adds actual arguments in failure message to make debugging test with ResqueSpec more easier.
Sample code for this change is here. https://github.com/kyanny/resque_spec_test
Before this change,
have_queuedmatcher shows these failure messages:After this change,
have_queuedmatcher shows more valuable failure messages: (see the difference in faillure message starts with but actually ...)