Fix for resque-heroku disconnecting DB #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful when using the resque-heroku gem, as it disconnects the database connection unless Resque.inline? per this commit: simple10/resque-heroku@a839554 The writer for ResqueSpec.inline = is what sets the value for Resque.inline
This ensures that resque-heroku does not close the connection.
Owner
|
Hi @justin808, Thanks! This looks good. I will be pulling this in after I consider a smallish tweak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the resque-heroku gem (simple10/resque-heroku@a839554), the database connection is killed after a job is run.
This patch addresses that issue.