Pr/save ascii

[ambs]

Howdy,

So long, but still fighting matrices (unfortunately not petting ducks :-) ).
Now for the real matter, I found it would be nice to have methods to save/load matrices from files.
I know I can slurp a file and use 'new_from_string', but I do not think that to be very efficient (as you need to construct the full string in memory, and then parse it). The same to save...

So, I know I miss tests and documentation. But for now what I want is:

• if you bless the creation of these methods
• if you want to change the methods names, or if I can keep them

If everything is good, I'll continue coding, and will poke you again when it is ready.

Cheers

[leto]

I will review this soon and get back to you

[ambs]

Some months later, @leto, do you mind to take a decision on this? :) Thank you!

[leto]

Oops! Sorry that this fell off my radar, @ambs. Feel free to remind me sooner in the future 😈

I like the functionality of this 👍 but I don't like the function names 👎 Perhaps save_to_file() and new_from_file() ? What was your motivation in putting "ascii" in the name? Otherwise, yes please continue on this track and write some tests and docs, too 🐪

[leto]

Or emulate the Math::GSL interface that many people are already used to?

https://github.com/leto/math--gsl/blob/master/pod/Matrix.pod#write

https://github.com/leto/math--gsl/blob/master/pod/Matrix.pod#read

[ambs]

Hey
I had other things to do, so this fell off my radar too :)

The motivation of using ASCII: sooner or later we might want another serialization format, like Sereal or Storable or ... or even some pack'ed format.

So, I would save write and read for the binary formats when they come.
Maybe use your save_to_file and new_from_file? No idea. Brainstorming is welcome :)

[leto]

Yeah, I like save_to_file and `new_from_file``, run with it!

[ambs]

Nice. Will create tests, then!

[ambs]

And here it is :) Have fun!

[leto]

👍 Can you add something to the ChangeLog?

[ambs]

And here it is.

[ambs]

Time to say:
http://www.quickmeme.com/img/f4/f455acb55158cba209be25aec02be788d9fe281d3372eba80a3a4c7fb5e3f8bb.jpg