Open
Conversation
|
@akiray03 just a friendly ping. Would it be possible to merge this PR and make a new release of the library? With PEP 585 type annotations becoming used in many codebases, lack of support for it makes this package less and less useful as time goes on. Which is a pity because it's otherwise great. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this package doesn't support PEP 585. And the stack trace is a little confusing.
For example:
This was confusing to me and it seems to other users (see: #20).
This PR adds support for generic type aliases while still maintaining backward compatibility with 3.8 (via some ugly version checks).