Fix incorrect word count for camelCase. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `word-count` is only determined on `flx-word-p` which doesn't break on camel-case changes. OTOH, `words-length` properly reflects the number of words (based on `flx-boundary-p`.
Owner
|
This change breaks legit tests (yay testing!). I will think about refactoring the code around this. It's pretty hard for me to parse the code 1+ years on though. |
Author
|
Well it probably breaks the examples which tested the wrong case originally. It seems only those where the property is violated fail. |
Owner
|
This is the valid test I'm talking about - https://github.com/lewang/flx/blob/master/tests/flx-test.el#L296 . |
Owner
|
I haven't forgotten about this. There are some other optimizations coming in and I'll revisit this after that PR is merged. |
Author
|
Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
word-countis only determined onflx-word-pwhich doesn'tbreak on camelCase changes. OTOH,
words-lengthproperly reflects thenumber of words (based on
flx-boundary-p.Further, we might probably want to remove the
word-countvariablealltogether, it doesn't serve any purpose as it just mirrors
words-lengthbut in an inconsistent way.