Allow passing in GH token

[axmmisaka]

GH API might rate-limit us which is a concern when running CI that fires a bunch of curl requests unless we provide a GH token. This PR allows us to do so.

[lhstrh]

Shouldn't the CI script then also pass in the auth token?

[axmmisaka]

Shouldn't the CI script then also pass in the auth token?

I have a diff here: axmmisaka/action-setup-lf@7f60b1e
But since GitHub Actions is a bit unpredictable I think we might need some more stress testing to make the PR...

[lhstrh]

How did you even figure out that this was a problem? 🤣 Note that this fix will only work in CI, not in actual use of the installer. If we don't want to be rate limited, we should probably just serve this differently. Could we just serve it via Pages? I imagine that wouldn't be rate limited as aggressively.

[axmmisaka]

How did you even figure out that this was a problem?

I tweaked the script to have set -euo pipefail and it shows it fails at resp=$(curl ...) part; I got rid of the -s in curl and it appears that we got 403/429, main reason being https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28

https://github.com/mxschmitt/action-tmate this is the ugliest form of debugging but works nicely

Note that this fix will only work in CI, not in actual use of the installer.

One use case I could think of is if people want to install LF onto a cluster of machines with this script (they shouldn't), they can supply their own token.

Could we just serve it via Pages? I imagine that wouldn't be rate limited as aggressively.

To be honest I'm not 100% sure...