Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to make it as easy as possible for people to try out the game.
This PR packages the number shoot out game such that someone can get the game by simply running
The above installs the dependencies (
viff,twisted,gmpy) and makesgenerate-config-files.pyandnumber_shoot_out.pyavailable as scripts.Eventually we could upload the game on PyPI, so that it could be installed with a simpler command, e.g.:
todo
to try the PR, you can do everything in one docker container:
(shell 1) installation
$ docker run --rm -it --name mpc-numbershootout python:2-stretch bash apt update && apt install -y libgmp-dev pip install --process-dependency-links git+https://github.com/sbellem/ic3_mpc.git@pkg-numbershoot-script(shell 1) config generation
(shell 1) player 1
(shell 2) player 2
(shell 3) player 3