Add overloadable attributes for vsnprintf and snprintf#149
Add overloadable attributes for vsnprintf and snprintf#149illiminable wants to merge 1 commit intolibcheck:masterfrom
Conversation
illiminable
commented
Dec 11, 2017
- Adds overloadable attributes for clang.
- Adds overloadable attributes for clang.
|
Ran into this while trying to port to Chrome OS. |
|
To date the project has been building against GCC and Clang both, but no build issue has been found. Are you seeing an issue on more recent versions of Clang? Can you provide more description to the problem which was found and how this solves it, so I can have a better understanding of what issue is being addressed? |
|
It may only be when using the -verify option, and if the standard library is appropriately annotated. ../../check-0.9.13/lib/libcompat.h:194:16: fatal error: redeclaration of 'rpl_vsnprintf' must have the 'overloadable' attribute |
|
Oh, OK. Is using -verify something that should be done in the CI builds to ensure now new breakage is introduced in the future? It sounds from the Clang documentation that -verify is used to pass information from the compiler to an IDE, but it is not entirely clear to me. Can you mention some of your comment in the commit message? I'll then merge the pull request. |