Skip to content

feat(QueryEditor): add line numbers toggle#28

Merged
cevheri merged 6 commits intolibredb:devfrom
kaya-abdullah:dev
Mar 2, 2026
Merged

feat(QueryEditor): add line numbers toggle#28
cevheri merged 6 commits intolibredb:devfrom
kaya-abdullah:dev

Conversation

@kaya-abdullah
Copy link
Contributor

@kaya-abdullah kaya-abdullah commented Feb 27, 2026

Description

added line numbers button to the bar

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Related Issue

Closes #

Changes Made

  • A button labeled #LINES has been added to the top bar. When pressed, the lines appear in the query screen below. Pressing it again makes these lines disappear.

Testing

  • I have tested this locally
  • I have added/updated tests
  • All existing tests pass

Test Environment

  • Browser:

Screenshots (if applicable)

image

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

@cevheri
Copy link
Contributor

cevheri commented Feb 27, 2026

Hi @kaya-abdullah fix or update unit & integration failed tests

@kaya-abdullah
Copy link
Contributor Author

Hi @kaya-abdullah fix or update unit & integration failed tests

Hello @cevheri , could you please check again. I have pushed the unit tests.

@cevheri cevheri merged commit 70bf6a2 into libredb:dev Mar 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants