fix: multi value binary column type guard#69
Open
sunsetkookaburra wants to merge 1 commit intolibyal:mainfrom
Open
fix: multi value binary column type guard#69sunsetkookaburra wants to merge 1 commit intolibyal:mainfrom
sunsetkookaburra wants to merge 1 commit intolibyal:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 22.19% 16.83% -5.37%
==========================================
Files 53 53
Lines 12299 12296 -3
Branches 2843 2842 -1
==========================================
- Hits 2730 2070 -660
- Misses 9141 9894 +753
+ Partials 428 332 -96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks for the proposed changes I'll have a look when time permits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libesedb_multi_value_get_value_binary_dataincorrectly guarded for text type instead of binary data. fixed in this patch