FAT and NTFS should not pass as MBR by signatures#5
Open
kgermanov wants to merge 2 commits intolibyal:mainfrom
Open
FAT and NTFS should not pass as MBR by signatures#5kgermanov wants to merge 2 commits intolibyal:mainfrom
kgermanov wants to merge 2 commits intolibyal:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
===========================================
- Coverage 55.21% 30.91% -24.31%
===========================================
Files 16 15 -1
Lines 1878 1695 -183
===========================================
- Hits 1037 524 -513
- Misses 841 1171 +330
Continue to review full report at Codecov.
|
Member
|
Thx for the suggested changes. Note that per README this project is experimental, I'll have a look when time permits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If pass NTFS/FAT volume instead of MBR disk, that wrong detected as MBR, because they are have same sector signatures. Need filter them.